-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dumper: added ext-ds support #484
Conversation
@dg The failure is not caused by my changes. |
Can you add a test? |
The test would of course require ext-ds to be installed. I'm not sure how to add it on your GitHub Actions setup. |
In this way: https://github.com/nette/latte/blob/master/.github/workflows/tests.yml#L20 (Probably |
@dg How do I run the tests locally? I tried
I have no idea why. I'm using json extension every day and in my code it always exists. So I'm very confused. Can you fix |
4a96a60
to
d1cf1f3
Compare
|
@milo thx for the advice, I fixed composer.json to use this option too. |
ad JsonSerializable: what operating system are you using? |
@dg Ubuntu but I don't think it's important. The issue is that nette/tester isn't using the system's default php.ini without the If there are reasons to not load the default php.ini in some scenarios then in my opinion it should work the other way around - use system's php.ini by default with an option to turn it off. |
The point is, it works for me on Windows and I had no idea there is such a problem. This has to be solved with a custom php.ini, I'll fix it so please don't change the composer.json. |
Alright, I removed the composer.json commit. Can you review the feature I'm adding? :-) |
Looks good, thanks |
Closes #472